chore: Install phpunit via vendor bin #40678
Conversation
|
alright. this seems to work. only one test fails because I forgot to adjust the working directory. @blizzz @come-nc @icewind1991 @kesselb @nickvergessen any objections here? my personal stretch goal is to standardize running phpunit tests through a composer script. I'm mostly annoyed by the slow and cumbersome dav unit tests. what I want is a simple and fast for those who never run tests locally there will be no change for now. |
| "config": { | ||
| "sort-packages": true, | ||
| "platform": { | ||
| "php": "8.0" |
There was a problem hiding this comment.
Sure. Once master doesn't work with 8.0 anymore we can bump the platform here 👍
There was a problem hiding this comment.
Well the point of #40636 is to update the CI before dropping 8.0.
Because I fear dropping 8.0 will be decided late in the release cycle.
We have a php lint step that checks all supported versions, it’s not needed for phpunit to run on the oldest one.
There was a problem hiding this comment.
If I drop the platform requirement here, composer will pull sub dependencies of phpunit that are incompatible with PHP8.0. So CI won't pass. It's really just about one incompatible package. There is an older version that works with 8.0 as well, which is installed now.
IMO dropping PHP8.0 support and removing it from CI is an atomic step. Either master doesn't support 8.0 and we don't test it, or it still supports it and we have tests. Dropping 8.0 CI now is a risk if 8.0 support is not removed in the this release cycle.
ChristophWurst
added
3. to review
This means we can all run the same version. And when switching to stableX it can pull the corresponding version too. Also local dev envs and CI run the same phpunit. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
chore/phpunit-vendor-bin
branch
from
0952d56 to
0e64ec6
Compare
Summary
This means we can all run the same version. And when switching to stableX it can pull the corresponding version too. Also local dev envs and CI run the same phpunit.
Set to draft until I know if this actually works.It works.TODO
Follow-ups
Checklist